/usr/lib/python2.7/dist-packages/ceph_volume_client.py is in python-cephfs 10.1.2-0ubuntu1.
This file is owned by root:root, with mode 0o644.
The actual contents of the file can be viewed below.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 | """
Copyright (C) 2015 Red Hat, Inc.
LGPL2. See file COPYING.
"""
import json
import logging
import os
import threading
import errno
import time
import rados
import cephfs
from ceph_argparse import json_command
class RadosError(Exception):
"""
Something went wrong talking to Ceph with librados
"""
pass
RADOS_TIMEOUT = 10
SNAP_DIR = ".snap"
log = logging.getLogger(__name__)
# Reserved volume group name which we use in paths for volumes
# that are not assigned to a group (i.e. created with group=None)
NO_GROUP_NAME = "_nogroup"
class VolumePath(object):
"""
Identify a volume's path as group->volume
The Volume ID is a unique identifier, but this is a much more
helpful thing to pass around.
"""
def __init__(self, group_id, volume_id):
self.group_id = group_id
self.volume_id = volume_id
assert self.group_id != NO_GROUP_NAME
def __str__(self):
return "{0}/{1}".format(self.group_id, self.volume_id)
class ClusterTimeout(Exception):
"""
Exception indicating that we timed out trying to talk to the Ceph cluster,
either to the mons, or to any individual daemon that the mons indicate ought
to be up but isn't responding to us.
"""
pass
class ClusterError(Exception):
"""
Exception indicating that the cluster returned an error to a command that
we thought should be successful based on our last knowledge of the cluster
state.
"""
def __init__(self, action, result_code, result_str):
self._action = action
self._result_code = result_code
self._result_str = result_str
def __str__(self):
return "Error {0} (\"{1}\") while {2}".format(
self._result_code, self._result_str, self._action)
class RankEvicter(threading.Thread):
"""
Thread for evicting client(s) from a particular MDS daemon instance.
This is more complex than simply sending a command, because we have to
handle cases where MDS daemons might not be fully up yet, and/or might
be transiently unresponsive to commands.
"""
class GidGone(Exception):
pass
POLL_PERIOD = 5
def __init__(self, volume_client, client_spec, rank, gid, mds_map, ready_timeout):
"""
:param client_spec: list of strings, used as filter arguments to "session evict"
pass ["id=123"] to evict a single client with session id 123.
"""
self.rank = rank
self.gid = gid
self._mds_map = mds_map
self._client_spec = client_spec
self._volume_client = volume_client
self._ready_timeout = ready_timeout
self._ready_waited = 0
self.success = False
self.exception = None
super(RankEvicter, self).__init__()
def _ready_to_evict(self):
if self._mds_map['up'].get("mds_{0}".format(self.rank), None) != self.gid:
log.info("Evicting {0} from {1}/{2}: rank no longer associated with gid, done.".format(
self._client_spec, self.rank, self.gid
))
raise RankEvicter.GidGone()
info = self._mds_map['info']["gid_{0}".format(self.gid)]
log.debug("_ready_to_evict: state={0}".format(info['state']))
return info['state'] in ["up:active", "up:clientreplay"]
def _wait_for_ready(self):
"""
Wait for that MDS rank to reach an active or clientreplay state, and
not be laggy.
"""
while not self._ready_to_evict():
if self._ready_waited > self._ready_timeout:
raise ClusterTimeout()
time.sleep(self.POLL_PERIOD)
self._ready_waited += self.POLL_PERIOD
self._mds_map = self._volume_client._rados_command("mds dump", {})
def _evict(self):
"""
Run the eviction procedure. Return true on success, false on errors.
"""
# Wait til the MDS is believed by the mon to be available for commands
try:
self._wait_for_ready()
except self.GidGone:
return True
# Then send it an evict
ret = errno.ETIMEDOUT
while ret == errno.ETIMEDOUT:
log.debug("mds_command: {0}, {1}".format(
"%s" % self.gid, ["session", "evict"] + self._client_spec
))
ret, outb, outs = self._volume_client.fs.mds_command(
"%s" % self.gid,
[json.dumps({
"prefix": "session evict",
"filters": self._client_spec
})], "")
log.debug("mds_command: complete {0} {1}".format(ret, outs))
# If we get a clean response, great, it's gone from that rank.
if ret == 0:
return True
elif ret == errno.ETIMEDOUT:
# Oh no, the MDS went laggy (that's how libcephfs knows to emit this error)
self._mds_map = self._volume_client._rados_command("mds dump", {})
try:
self._wait_for_ready()
except self.GidGone:
return True
else:
raise ClusterError("Sending evict to mds.{0}".format(self.gid), ret, outs)
def run(self):
try:
self._evict()
except Exception, e:
self.success = False
self.exception = e
else:
self.success = True
class EvictionError(Exception):
pass
class CephFSVolumeClient(object):
"""
Combine libcephfs and librados interfaces to implement a
'Volume' concept implemented as a cephfs directory and
client capabilities which restrict mount access to this
directory.
Additionally, volumes may be in a 'Group'. Conveniently,
volumes are a lot like manila shares, and groups are a lot
like manila consistency groups.
Refer to volumes with VolumePath, which specifies the
volume and group IDs (both strings). The group ID may
be None.
In general, functions in this class are allowed raise rados.Error
or cephfs.Error exceptions in unexpected situations.
"""
# Where shall we create our volumes?
VOLUME_PREFIX = "/volumes"
POOL_PREFIX = "fsvolume_"
def __init__(self, auth_id, conf_path, cluster_name):
self.fs = None
self.rados = None
self.connected = False
self.conf_path = conf_path
self.cluster_name = cluster_name
self.auth_id = auth_id
def evict(self, auth_id, timeout=30):
"""
Evict all clients using this authorization ID. Assumes that the
authorisation key has been revoked prior to calling this function.
This operation can throw an exception if the mon cluster is unresponsive, or
any individual MDS daemon is unresponsive for longer than the timeout passed in.
"""
log.info("evict: {0}".format(auth_id))
mds_map = self._rados_command("mds dump", {})
up = {}
for name, gid in mds_map['up'].items():
# Quirk of the MDSMap JSON dump: keys in the up dict are like "mds_0"
assert name.startswith("mds_")
up[int(name[4:])] = gid
# For all MDS ranks held by a daemon
# Do the parallelism in python instead of using "tell mds.*", because
# the latter doesn't give us per-mds output
threads = []
for rank, gid in up.items():
thread = RankEvicter(self, ["auth_name={0}".format(auth_id)], rank, gid, mds_map, timeout)
thread.start()
threads.append(thread)
for t in threads:
t.join()
log.info("evict: joined all")
for t in threads:
if not t.success:
msg = "Failed to evict client {0} from mds {1}/{2}: {3}".format(
auth_id, t.rank, t.gid, t.exception
)
log.error(msg)
raise EvictionError(msg)
def _get_path(self, volume_path):
"""
Determine the path within CephFS where this volume will live
:return: absolute path (string)
"""
return os.path.join(
self.VOLUME_PREFIX,
volume_path.group_id if volume_path.group_id is not None else NO_GROUP_NAME,
volume_path.volume_id)
def _get_group_path(self, group_id):
if group_id is None:
raise ValueError("group_id may not be None")
return os.path.join(
self.VOLUME_PREFIX,
group_id
)
def connect(self, premount_evict = None):
"""
:param premount_evict: Optional auth_id to evict before mounting the filesystem: callers
may want to use this to specify their own auth ID if they expect
to be a unique instance and don't want to wait for caps to time
out after failure of another instance of themselves.
"""
log.debug("Connecting to RADOS with config {0}...".format(self.conf_path))
self.rados = rados.Rados(
name="client.{0}".format(self.auth_id),
clustername=self.cluster_name,
conffile=self.conf_path,
conf={}
)
self.rados.connect()
log.debug("Connection to RADOS complete")
log.debug("Connecting to cephfs...")
self.fs = cephfs.LibCephFS(rados_inst=self.rados)
log.debug("CephFS initializing...")
self.fs.init()
if premount_evict is not None:
log.debug("Premount eviction of {0} starting".format(premount_evict))
self.evict(premount_evict)
log.debug("Premount eviction of {0} completes".format(premount_evict))
log.debug("CephFS mounting...")
self.fs.mount()
log.debug("Connection to cephfs complete")
def get_mon_addrs(self):
log.info("get_mon_addrs")
result = []
mon_map = self._rados_command("mon dump")
for mon in mon_map['mons']:
ip_port = mon['addr'].split("/")[0]
result.append(ip_port)
return result
def disconnect(self):
log.info("disconnect")
if self.fs:
log.debug("Disconnecting cephfs...")
self.fs.shutdown()
self.fs = None
log.debug("Disconnecting cephfs complete")
if self.rados:
log.debug("Disconnecting rados...")
self.rados.shutdown()
self.rados = None
log.debug("Disconnecting rados complete")
def __del__(self):
self.disconnect()
def _get_pool_id(self, osd_map, pool_name):
# Maybe borrow the OSDMap wrapper class from calamari if more helpers like this aren't needed.
for pool in osd_map['pools']:
if pool['pool_name'] == pool_name:
return pool['pool']
return None
def _create_volume_pool(self, pool_name):
"""
Idempotently create a pool for use as a CephFS data pool, with the given name
:return The ID of the created pool
"""
osd_map = self._rados_command('osd dump', {})
existing_id = self._get_pool_id(osd_map, pool_name)
if existing_id is not None:
log.info("Pool {0} already exists".format(pool_name))
return existing_id
osd_count = len(osd_map['osds'])
# We can't query the actual cluster config remotely, but since this is
# just a heuristic we'll assume that the ceph.conf we have locally reflects
# that in use in the rest of the cluster.
pg_warn_max_per_osd = int(self.rados.conf_get('mon_pg_warn_max_per_osd'))
other_pgs = 0
for pool in osd_map['pools']:
if not pool['pool_name'].startswith(self.POOL_PREFIX):
other_pgs += pool['pg_num']
# A basic heuristic for picking pg_num: work out the max number of
# PGs we can have without tripping a warning, then subtract the number
# of PGs already created by non-manila pools, then divide by ten. That'll
# give you a reasonable result on a system where you have "a few" manila
# shares.
pg_num = ((pg_warn_max_per_osd * osd_count) - other_pgs) / 10
# TODO Alternatively, respect an override set by the user.
self._rados_command(
'osd pool create',
{
'pool': pool_name,
'pg_num': pg_num
}
)
osd_map = self._rados_command('osd dump', {})
pool_id = self._get_pool_id(osd_map, pool_name)
if pool_id is None:
# If the pool isn't there, that's either a ceph bug, or it's some outside influence
# removing it right after we created it.
log.error("OSD map doesn't contain expected pool '{0}':\n{1}".format(
pool_name, json.dumps(osd_map, indent=2)
))
raise RuntimeError("Pool '{0}' not present in map after creation".format(pool_name))
else:
return pool_id
def create_group(self, group_id):
path = self._get_group_path(group_id)
self._mkdir_p(path)
def destroy_group(self, group_id):
path = self._get_group_path(group_id)
try:
self.fs.stat(self.VOLUME_PREFIX)
except cephfs.ObjectNotFound:
pass
else:
self.fs.rmdir(path)
def _mkdir_p(self, path):
try:
self.fs.stat(path)
except cephfs.ObjectNotFound:
pass
else:
return
parts = path.split(os.path.sep)
for i in range(1, len(parts) + 1):
subpath = os.path.join(*parts[0:i])
try:
self.fs.stat(subpath)
except cephfs.ObjectNotFound:
self.fs.mkdir(subpath, 0755)
def create_volume(self, volume_path, size=None, data_isolated=False):
"""
Set up metadata, pools and auth for a volume.
This function is idempotent. It is safe to call this again
for an already-created volume, even if it is in use.
:param volume_path: VolumePath instance
:param size: In bytes, or None for no size limit
:param data_isolated: If true, create a separate OSD pool for this volume
:return:
"""
log.info("create_volume: {0}".format(volume_path))
path = self._get_path(volume_path)
self._mkdir_p(path)
if size is not None:
self.fs.setxattr(path, 'ceph.quota.max_bytes', size.__str__(), 0)
if data_isolated:
pool_name = "{0}{1}".format(self.POOL_PREFIX, volume_path.volume_id)
pool_id = self._create_volume_pool(pool_name)
mds_map = self._rados_command("mds dump", {})
if pool_id not in mds_map['data_pools']:
self._rados_command("mds add_data_pool", {
'pool': pool_name
})
self.fs.setxattr(path, 'ceph.dir.layout.pool', pool_name, 0)
return {
'mount_path': path
}
def delete_volume(self, volume_path, data_isolated=False):
"""
Make a volume inaccessible to guests. This function is
idempotent. This is the fast part of tearing down a volume: you must
also later call purge_volume, which is the slow part.
:param volume_path: Same identifier used in create_volume
:return:
"""
log.info("delete_volume: {0}".format(volume_path))
# Create the trash folder if it doesn't already exist
trash = os.path.join(self.VOLUME_PREFIX, "_deleting")
self._mkdir_p(trash)
# We'll move it to here
trashed_volume = os.path.join(trash, volume_path.volume_id)
# Move the volume's data to the trash folder
path = self._get_path(volume_path)
try:
self.fs.stat(path)
except cephfs.ObjectNotFound:
log.warning("Trying to delete volume '{0}' but it's already gone".format(
path))
else:
self.fs.rename(path, trashed_volume)
def purge_volume(self, volume_path, data_isolated=False):
"""
Finish clearing up a volume that was previously passed to delete_volume. This
function is idempotent.
"""
trash = os.path.join(self.VOLUME_PREFIX, "_deleting")
trashed_volume = os.path.join(trash, volume_path.volume_id)
try:
self.fs.stat(trashed_volume)
except cephfs.ObjectNotFound:
log.warning("Trying to purge volume '{0}' but it's already been purged".format(
trashed_volume))
return
def rmtree(root_path):
log.debug("rmtree {0}".format(root_path))
dir_handle = self.fs.opendir(root_path)
d = self.fs.readdir(dir_handle)
while d:
if d.d_name not in [".", ".."]:
d_full = os.path.join(root_path, d.d_name)
if d.is_dir():
rmtree(d_full)
else:
self.fs.unlink(d_full)
d = self.fs.readdir(dir_handle)
self.fs.closedir(dir_handle)
self.fs.rmdir(root_path)
rmtree(trashed_volume)
if data_isolated:
pool_name = "{0}{1}".format(self.POOL_PREFIX, volume_path.volume_id)
osd_map = self._rados_command("osd dump", {})
pool_id = self._get_pool_id(osd_map, pool_name)
mds_map = self._rados_command("mds dump", {})
if pool_id in mds_map['data_pools']:
self._rados_command("mds remove_data_pool", {
'pool': pool_name
})
self._rados_command("osd pool delete",
{
"pool": pool_name,
"pool2": pool_name,
"sure": "--yes-i-really-really-mean-it"
})
def _get_ancestor_xattr(self, path, attr):
"""
Helper for reading layout information: if this xattr is missing
on the requested path, keep checking parents until we find it.
"""
try:
result = self.fs.getxattr(path, attr)
if result == "":
# Annoying! cephfs gives us empty instead of an error when attr not found
raise cephfs.NoData()
else:
return result
except cephfs.NoData:
if path == "/":
raise
else:
return self._get_ancestor_xattr(os.path.split(path)[0], attr)
def authorize(self, volume_path, auth_id):
"""
Get-or-create a Ceph auth identity for `auth_id` and grant them access
to
:param volume_path:
:param auth_id:
:return:
"""
# First I need to work out what the data pool is for this share:
# read the layout
path = self._get_path(volume_path)
pool_name = self._get_ancestor_xattr(path, "ceph.dir.layout.pool")
# Now construct auth capabilities that give the guest just enough
# permissions to access the share
client_entity = "client.{0}".format(auth_id)
want_mds_cap = 'allow rw path={0}'.format(path)
want_osd_cap = 'allow rw pool={0}'.format(pool_name)
try:
existing = self._rados_command(
'auth get',
{
'entity': client_entity
}
)
# FIXME: rados raising Error instead of ObjectNotFound in auth get failure
except rados.Error:
caps = self._rados_command(
'auth get-or-create',
{
'entity': client_entity,
'caps': [
'mds', want_mds_cap,
'osd', want_osd_cap,
'mon', 'allow r']
})
else:
# entity exists, extend it
cap = existing[0]
def cap_extend(orig, want):
cap_tokens = orig.split(",")
if want not in cap_tokens:
cap_tokens.append(want)
return ",".join(cap_tokens)
osd_cap_str = cap_extend(cap['caps'].get('osd', ""), want_osd_cap)
mds_cap_str = cap_extend(cap['caps'].get('mds', ""), want_mds_cap)
caps = self._rados_command(
'auth caps',
{
'entity': client_entity,
'caps': [
'mds', mds_cap_str,
'osd', osd_cap_str,
'mon', cap['caps'].get('mon')]
})
caps = self._rados_command(
'auth get',
{
'entity': client_entity
}
)
# Result expected like this:
# [
# {
# "entity": "client.foobar",
# "key": "AQBY0\/pViX\/wBBAAUpPs9swy7rey1qPhzmDVGQ==",
# "caps": {
# "mds": "allow *",
# "mon": "allow *"
# }
# }
# ]
assert len(caps) == 1
assert caps[0]['entity'] == client_entity
key = caps[0]['key']
return {
'auth_key': key
}
def deauthorize(self, volume_path, auth_id):
"""
The volume must still exist.
"""
client_entity = "client.{0}".format(auth_id)
path = self._get_path(volume_path)
pool_name = self._get_ancestor_xattr(path, "ceph.dir.layout.pool")
want_mds_cap = 'allow rw path={0}'.format(path)
want_osd_cap = 'allow rw pool={0}'.format(pool_name)
try:
existing = self._rados_command(
'auth get',
{
'entity': client_entity
}
)
def cap_remove(orig, want):
cap_tokens = orig.split(",")
if want in cap_tokens:
cap_tokens.remove(want)
return ",".join(cap_tokens)
cap = existing[0]
osd_cap_str = cap_remove(cap['caps'].get('osd', ""), want_osd_cap)
mds_cap_str = cap_remove(cap['caps'].get('mds', ""), want_mds_cap)
if (not osd_cap_str) and (not mds_cap_str):
self._rados_command('auth del', {'entity': client_entity}, decode=False)
else:
self._rados_command(
'auth caps',
{
'entity': client_entity,
'caps': [
'mds', mds_cap_str,
'osd', osd_cap_str,
'mon', cap['caps'].get('mon')]
})
# FIXME: rados raising Error instead of ObjectNotFound in auth get failure
except rados.Error:
# Already gone, great.
return
def _rados_command(self, prefix, args=None, decode=True):
"""
Safer wrapper for ceph_argparse.json_command, which raises
Error exception instead of relying on caller to check return
codes.
Error exception can result from:
* Timeout
* Actual legitimate errors
* Malformed JSON output
return: Decoded object from ceph, or None if empty string returned.
If decode is False, return a string (the data returned by
ceph command)
"""
if args is None:
args = {}
argdict = args.copy()
argdict['format'] = 'json'
ret, outbuf, outs = json_command(self.rados,
prefix=prefix,
argdict=argdict,
timeout=RADOS_TIMEOUT)
if ret != 0:
raise rados.Error(outs)
else:
if decode:
if outbuf:
try:
return json.loads(outbuf)
except (ValueError, TypeError):
raise RadosError("Invalid JSON output for command {0}".format(argdict))
else:
return None
else:
return outbuf
def get_used_bytes(self, volume_path):
return int(self.fs.getxattr(self._get_path(volume_path), "ceph.dir.rbytes"))
def set_max_bytes(self, volume_path, max_bytes):
self.fs.setxattr(self._get_path(volume_path), 'ceph.quota.max_bytes',
max_bytes.__str__() if max_bytes is not None else "0",
0)
def _snapshot_path(self, dir_path, snapshot_name):
return os.path.join(
dir_path, SNAP_DIR, snapshot_name
)
def _snapshot_create(self, dir_path, snapshot_name):
# TODO: raise intelligible exception for clusters where snaps are disabled
self.fs.mkdir(self._snapshot_path(dir_path, snapshot_name), 0755)
def _snapshot_destroy(self, dir_path, snapshot_name):
"""
Remove a snapshot, or do nothing if it already doesn't exist.
"""
try:
self.fs.rmdir(self._snapshot_path(dir_path, snapshot_name))
except cephfs.ObjectNotFound:
log.warn("Snapshot was already gone: {0}".format(snapshot_name))
def create_snapshot_volume(self, volume_path, snapshot_name):
self._snapshot_create(self._get_path(volume_path), snapshot_name)
def destroy_snapshot_volume(self, volume_path, snapshot_name):
self._snapshot_destroy(self._get_path(volume_path), snapshot_name)
def create_snapshot_group(self, group_id, snapshot_name):
if group_id is None:
raise RuntimeError("Group ID may not be None")
return self._snapshot_create(self._get_group_path(group_id), snapshot_name)
def destroy_snapshot_group(self, group_id, snapshot_name):
if group_id is None:
raise RuntimeError("Group ID may not be None")
if snapshot_name is None:
raise RuntimeError("Snapshot name may not be None")
return self._snapshot_destroy(self._get_group_path(group_id), snapshot_name)
def _cp_r(self, src, dst):
# TODO
raise NotImplementedError()
def clone_volume_to_existing(self, dest_volume_path, src_volume_path, src_snapshot_name):
dest_fs_path = self._get_path(dest_volume_path)
src_snapshot_path = self._snapshot_path(self._get_path(src_volume_path), src_snapshot_name)
self._cp_r(src_snapshot_path, dest_fs_path)
|