/usr/lib/python3/dist-packages/clickreviews/common.py is in click-reviewers-tools 0.42.
This file is owned by root:root, with mode 0o644.
The actual contents of the file can be viewed below.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 | '''common.py: common classes and functions'''
#
# Copyright (C) 2013-2016 Canonical Ltd.
#
# This program is free software: you can redistribute it and/or modify
# it under the terms of the GNU General Public License as published by
# the Free Software Foundation; version 3 of the License.
#
# This program is distributed in the hope that it will be useful,
# but WITHOUT ANY WARRANTY; without even the implied warranty of
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
# GNU General Public License for more details.
#
# You should have received a copy of the GNU General Public License
# along with this program. If not, see <http://www.gnu.org/licenses/>.
from __future__ import print_function
import atexit
import codecs
import inspect
import json
import logging
import magic
import os
import re
import shutil
import subprocess
import sys
import tempfile
import types
DEBUGGING = False
UNPACK_DIR = None
RAW_UNPACK_DIR = None
TMP_DIR = None
VALID_SYSCALL = r'^[a-z0-9_]{2,64}$'
# This needs to match up with snapcraft
MKSQUASHFS_OPTS = ['-noappend', '-comp', 'xz', '-all-root', '-no-xattrs']
# There are quite a few kernel interfaces that can cause problems with
# long profile names. These are outlined in
# https://launchpad.net/bugs/1499544. The big issue is that the audit
# message must fit within PAGE_SIZE (at least 4096 on supported archs),
# so long names could push the audit message to be too big, which would
# result in a denial for that rule (but, only if the rule would've
# allowed it). Giving a hard-error on maxlen since we know that this
# will be a problem. The advisory length is what it is since we know
# that compound labels are sometimes logged and so a snappy system
# running an app in a snappy container or a QA testbed running apps
# under LXC
AA_PROFILE_NAME_MAXLEN = 230 # 245 minus a bit for child profiles
AA_PROFILE_NAME_ADVLEN = 100
def cleanup_unpack():
global UNPACK_DIR
if UNPACK_DIR is not None and os.path.isdir(UNPACK_DIR):
recursive_rm(UNPACK_DIR)
UNPACK_DIR = None
global RAW_UNPACK_DIR
if RAW_UNPACK_DIR is not None and os.path.isdir(RAW_UNPACK_DIR):
recursive_rm(RAW_UNPACK_DIR)
RAW_UNPACK_DIR = None
global TMP_DIR
if TMP_DIR is not None and os.path.isdir(TMP_DIR):
recursive_rm(TMP_DIR)
TMP_DIR = None
atexit.register(cleanup_unpack)
#
# Utility classes
#
class ReviewException(Exception):
'''This class represents Review exceptions'''
def __init__(self, value):
self.value = value
def __str__(self):
return repr(self.value)
class Review(object):
'''Common review class'''
magic_binary_file_descriptions = [
'application/x-executable; charset=binary',
'application/x-sharedlib; charset=binary',
'application/x-object; charset=binary',
'application/octet-stream; charset=binary'
]
def __init__(self, fn, review_type, overrides=None):
self.pkg_filename = fn
self._check_package_exists()
self.review_type = review_type
# TODO: rename as pkg_report
self.click_report = dict()
self.result_types = ['info', 'warn', 'error']
for r in self.result_types:
self.click_report[r] = dict()
self.click_report_output = "json"
global UNPACK_DIR
if UNPACK_DIR is None:
UNPACK_DIR = unpack_pkg(fn)
self.unpack_dir = UNPACK_DIR
global RAW_UNPACK_DIR
if RAW_UNPACK_DIR is None:
RAW_UNPACK_DIR = raw_unpack_pkg(fn)
self.raw_unpack_dir = RAW_UNPACK_DIR
self.is_click = False
self.is_snap1 = False
self.is_snap2 = False
self.pkgfmt = {"type": "", "version": ""}
(self.pkgfmt["type"], pkgver) = detect_package(fn, self.unpack_dir)
if self._pkgfmt_type() == "snap":
if pkgver < 2:
self.is_snap1 = True
self.pkgfmt["version"] = "15.04"
else:
self.is_snap2 = True
self.pkgfmt["version"] = "16.04"
elif self._pkgfmt_type() == "click":
self.pkgfmt["version"] = "0.4"
self.is_click = True
else:
error("Unknown package type: '%s'" % self._pkgfmt_type())
# Get a list of all unpacked files
self.pkg_files = []
self._list_all_files()
# Setup what is needed to get a list of all unpacked compiled binaries
self.mime = magic.open(magic.MAGIC_MIME)
self.mime.load()
self.pkg_bin_files = []
# Don't run this here since only cr_lint.py and cr_functional.py need
# it now
# self._list_all_compiled_binaries()
self.overrides = overrides if overrides is not None else {}
def _check_innerpath_executable(self, fn):
'''Check that the provided path exists and is executable'''
return os.access(fn, os.X_OK)
def _extract_statinfo(self, fn):
'''Extract statinfo from file'''
try:
st = os.stat(fn)
except Exception:
return None
return st
def _path_join(self, dirname, rest):
return os.path.join(dirname, rest)
def _get_sha512sum(self, fn):
'''Get sha512sum of file'''
(rc, out) = cmd(['sha512sum', fn])
if rc != 0:
return None
return out.split()[0]
def _pkgfmt_type(self):
'''Return the package format type'''
if "type" not in self.pkgfmt:
return ""
return self.pkgfmt["type"]
def _pkgfmt_version(self):
'''Return the package format version'''
if "version" not in self.pkgfmt:
return ""
return self.pkgfmt["version"]
def _check_package_exists(self):
'''Check that the provided package exists'''
if not os.path.exists(self.pkg_filename):
error("Could not find '%s'" % self.pkg_filename)
def _list_all_files(self):
'''List all files included in this click package.'''
for root, dirnames, filenames in os.walk(self.unpack_dir):
for f in filenames:
self.pkg_files.append(os.path.join(root, f))
def _check_if_message_catalog(self, fn):
'''Check if file is a message catalog (.mo file).'''
if fn.endswith('.mo'):
return True
return False
def _list_all_compiled_binaries(self):
'''List all compiled binaries in this click package.'''
for i in self.pkg_files:
res = self.mime.file(i)
if res in self.magic_binary_file_descriptions and \
not self._check_if_message_catalog(i):
self.pkg_bin_files.append(i)
def _get_check_name(self, name, app='', extra=''):
name = ':'.join([self.review_type, name])
if app:
name += ':' + app
if extra:
name += ':' + extra
return name
def _verify_pkgversion(self, v):
'''Verify package name'''
if not isinstance(v, (str, int, float)):
return False
re_valid_version = re.compile(r'^((\d+):)?' # epoch
'([A-Za-z0-9.+:~-]+?)' # upstream
'(-([A-Za-z0-9+.~]+))?$') # debian
if re_valid_version.match(str(v)):
return True
return False
def _get_policy_versions(self, vendor):
'''Get the supported AppArmor policy versions'''
if not self.aa_policy:
return None
if vendor not in self.aa_policy:
error("Could not find vendor '%s'" % vendor, do_exit=False)
return None
supported_policy_versions = []
for i in self.aa_policy[vendor].keys():
supported_policy_versions.append("%.1f" % float(i))
return sorted(supported_policy_versions)
def _get_templates(self, vendor, version, aa_type="all"):
'''Get templates by type'''
if not self.aa_policy:
return None
templates = []
if aa_type == "all":
for k in self.aa_policy[vendor][version]['templates'].keys():
templates += self.aa_policy[vendor][version]['templates'][k]
else:
templates = self.aa_policy[vendor][version]['templates'][aa_type]
return sorted(templates)
def _has_policy_version(self, vendor, version):
'''Determine if has specified policy version'''
if not self.aa_policy:
return None
if vendor not in self.aa_policy:
error("Could not find vendor '%s'" % vendor, do_exit=False)
return False
if str(version) not in self.aa_policy[vendor]:
return False
return True
def _get_policy_groups(self, vendor, version, aa_type="all"):
'''Get policy groups by type'''
if not self.aa_policy:
return None
groups = []
if vendor not in self.aa_policy:
error("Could not find vendor '%s'" % vendor, do_exit=False)
return groups
if not self._has_policy_version(vendor, version):
error("Could not find version '%s'" % version, do_exit=False)
return groups
v = str(version)
if aa_type == "all":
for k in self.aa_policy[vendor][v]['policy_groups'].keys():
groups += self.aa_policy[vendor][v]['policy_groups'][k]
else:
groups = self.aa_policy[vendor][v]['policy_groups'][aa_type]
return sorted(groups)
def _get_policy_group_type(self, vendor, version, policy_group):
'''Return policy group type'''
if not self.aa_policy:
return None
for t in self.aa_policy[vendor][version]['policy_groups']:
if policy_group in self.aa_policy[vendor][version]['policy_groups'][t]:
return t
return None
def _get_template_type(self, vendor, version, template):
'''Return template type'''
if not self.aa_policy:
return None
for t in self.aa_policy[vendor][version]['templates']:
if template in self.aa_policy[vendor][version]['templates'][t]:
return t
return None
# click_report[<result_type>][<review_name>] = <result>
# result_type: info, warn, error
# review_name: name of the check (prefixed with self.review_type)
# result: contents of the review
def _add_result(self, result_type, review_name, result, link=None,
manual_review=False):
'''Add result to report'''
if result_type not in self.result_types:
error("Invalid result type '%s'" % result_type)
if review_name not in self.click_report[result_type]:
# log info about check so it can be collected into the
# check-names.list file
# format should be
# CHECK|<review_type:check_name>|<link>
msg = 'CHECK|{}|{}'
name = ':'.join(review_name.split(':')[:2])
link_text = link if link is not None else ""
logging.debug(msg.format(name, link_text))
self.click_report[result_type][review_name] = dict()
self.click_report[result_type][review_name].update({
'text': result,
'manual_review': manual_review,
})
if link is not None:
self.click_report[result_type][review_name]["link"] = link
def do_report(self):
'''Print report'''
if self.click_report_output == "console":
# TODO: format better
import pprint
pprint.pprint(self.click_report)
elif self.click_report_output == "json":
import json
msg(json.dumps(self.click_report,
sort_keys=True,
indent=2,
separators=(',', ': ')))
rc = 0
if len(self.click_report['error']):
rc = 2
elif len(self.click_report['warn']):
rc = 1
return rc
def do_checks(self):
'''Run all methods that start with check_'''
methodList = [name for name, member in
inspect.getmembers(self, inspect.ismethod)
if isinstance(member, types.MethodType)]
for methodname in methodList:
if not methodname.startswith("check_"):
continue
func = getattr(self, methodname)
func()
def set_review_type(self, name):
'''Set review name'''
self.review_type = name
#
# Utility functions
#
def error(out, exit_code=1, do_exit=True):
'''Print error message and exit'''
try:
print("ERROR: %s" % (out), file=sys.stderr)
except IOError:
pass
if do_exit:
sys.exit(exit_code)
def warn(out):
'''Print warning message'''
try:
print("WARN: %s" % (out), file=sys.stderr)
except IOError:
pass
def msg(out, output=sys.stdout):
'''Print message'''
try:
print("%s" % (out), file=output)
except IOError:
pass
def debug(out):
'''Print debug message'''
global DEBUGGING
if DEBUGGING:
try:
print("DEBUG: %s" % (out), file=sys.stderr)
except IOError:
pass
def cmd(command):
'''Try to execute the given command.'''
debug(command)
try:
sp = subprocess.Popen(command, stdout=subprocess.PIPE,
stderr=subprocess.STDOUT)
except OSError as ex:
return [127, str(ex)]
if sys.version_info[0] >= 3:
out = sp.communicate()[0].decode('ascii', 'ignore')
else:
out = sp.communicate()[0]
return [sp.returncode, out]
def cmd_pipe(command1, command2):
'''Try to pipe command1 into command2.'''
try:
sp1 = subprocess.Popen(command1, stdout=subprocess.PIPE)
sp2 = subprocess.Popen(command2, stdin=sp1.stdout)
except OSError as ex:
return [127, str(ex)]
if sys.version_info[0] >= 3:
out = sp2.communicate()[0].decode('ascii', 'ignore')
else:
out = sp2.communicate()[0]
return [sp2.returncode, out]
def _unpack_cmd(cmd_args, d, dest):
'''Low level unpack helper'''
curdir = os.getcwd()
os.chdir(d)
(rc, out) = cmd(cmd_args)
os.chdir(curdir)
if rc != 0:
if os.path.isdir(d):
recursive_rm(d)
error("unpacking failed with '%d':\n%s" % (rc, out))
if dest is None:
dest = d
else:
shutil.move(d, dest)
return dest
def _unpack_snap_squashfs(snap_pkg, dest):
'''Unpack a squashfs based snap package to dest'''
d = tempfile.mkdtemp(prefix='review-')
return _unpack_cmd(['unsquashfs', '-f', '-d', d,
os.path.abspath(snap_pkg)], d, dest)
def _unpack_click_deb(pkg, dest):
d = tempfile.mkdtemp(prefix='review-')
return _unpack_cmd(['dpkg-deb', '-R',
os.path.abspath(pkg), d], d, dest)
def unpack_pkg(fn, dest=None):
'''Unpack package'''
if not os.path.isfile(fn):
error("Could not find '%s'" % fn)
pkg = fn
if not pkg.startswith('/'):
pkg = os.path.abspath(pkg)
if dest is not None and os.path.exists(dest):
error("'%s' exists. Aborting." % dest)
# check if its a squashfs based snap
if is_squashfs(pkg):
return _unpack_snap_squashfs(fn, dest)
return _unpack_click_deb(fn, dest)
def is_squashfs(filename):
'''Return true if the given filename as a squashfs header'''
with open(filename, 'rb') as f:
header = f.read(10)
return header.startswith(b"hsqs")
def raw_unpack_pkg(fn, dest=None):
'''Unpack raw package'''
if not os.path.isfile(fn):
error("Could not find '%s'" % fn)
pkg = fn
if not pkg.startswith('/'):
pkg = os.path.abspath(pkg)
# nothing to do for squashfs images
if is_squashfs(pkg):
return ""
if dest is not None and os.path.exists(dest):
error("'%s' exists. Aborting." % dest)
d = tempfile.mkdtemp(prefix='review-')
curdir = os.getcwd()
os.chdir(d)
(rc, out) = cmd(['ar', 'x', pkg])
os.chdir(curdir)
if rc != 0:
if os.path.isdir(d):
recursive_rm(d)
error("'ar x' failed with '%d':\n%s" % (rc, out))
if dest is None:
dest = d
else:
shutil.move(d, dest)
return dest
def create_tempdir():
'''Create/reuse a temporary directory that is automatically cleaned up'''
global TMP_DIR
if TMP_DIR is None:
TMP_DIR = tempfile.mkdtemp(prefix='review-')
return TMP_DIR
def open_file_read(path):
'''Open specified file read-only'''
try:
orig = codecs.open(path, 'r', "UTF-8")
except Exception:
raise
return orig
def recursive_rm(dirPath, contents_only=False):
'''recursively remove directory'''
names = os.listdir(dirPath)
for name in names:
path = os.path.join(dirPath, name)
if os.path.islink(path) or not os.path.isdir(path):
os.unlink(path)
else:
recursive_rm(path)
if contents_only is False:
os.rmdir(dirPath)
def run_check(cls):
if len(sys.argv) < 2:
error("Must give path to package")
# extract args
fn = sys.argv[1]
if len(sys.argv) > 2:
overrides = json.loads(sys.argv[2])
else:
overrides = None
review = cls(fn, overrides=overrides)
review.do_checks()
rc = review.do_report()
sys.exit(rc)
def detect_package(fn, dir=None):
'''Detect what type of package this is'''
pkgtype = None
pkgver = None
if not os.path.isfile(fn):
error("Could not find '%s'" % fn)
if dir is None:
unpack_dir = unpack_pkg(fn)
else:
unpack_dir = dir
if not os.path.isdir(unpack_dir):
error("Could not find '%s'" % unpack_dir)
pkg = fn
if not pkg.startswith('/'):
pkg = os.path.abspath(pkg)
# check if its a squashfs based snap
if is_squashfs(pkg):
# 16.04+ squashfs snaps
pkgtype = "snap"
pkgver = 2
elif os.path.exists(os.path.join(unpack_dir, "meta/package.yaml")):
# 15.04 ar-based snaps
pkgtype = "snap"
pkgver = 1
else:
pkgtype = "click"
pkgver = 1
if dir is None and os.path.isdir(unpack_dir):
recursive_rm(unpack_dir)
return (pkgtype, pkgver)
def find_external_symlinks(unpack_dir, pkg_files):
'''Check if symlinks in the package go out to the system.'''
common = '(-[0-9.]+)?\.so(\.[0-9.]+)?'
libc6_libs = ['ld-*.so',
'libanl',
'libBrokenLocale',
'libc',
'libcidn',
'libcrypt',
'libdl',
'libmemusage',
'libm',
'libnsl',
'libnss_compat',
'libnss_dns',
'libnss_files',
'libnss_hesiod',
'libnss_nisplus',
'libnss_nis',
'libpcprofile',
'libpthread',
'libresolv',
'librt',
'libSegFault',
'libthread_db',
'libutil',
]
libc6_pats = []
for lib in libc6_libs:
libc6_pats.append(re.compile(r'%s%s' % (lib, common)))
libc6_pats.append(re.compile(r'ld-*.so$'))
libc6_pats.append(re.compile(r'ld-linux-*.so\.[0-9.]+$'))
def _in_patterns(pats, f):
for pat in pats:
if pat.search(f):
return True
return False
external_symlinks = list(filter(lambda link: not
os.path.realpath(link).startswith(
unpack_dir) and
not _in_patterns(libc6_pats,
os.path.basename(link)),
pkg_files))
return [os.path.relpath(i, unpack_dir) for i in external_symlinks]
# check_results(report, expected_counts, expected)
# Verify exact counts of types
# expected_counts={'info': 1, 'warn': 0, 'error': 0}
# self.check_results(report, expected_counts)
# Verify counts of warn and error types
# expected_counts={'info': None, 'warn': 0, 'error': 0}
# self.check_results(report, expected_counts)
# Verify exact messages:
# expected = dict()
# expected['info'] = dict()
# expected['warn'] = dict()
# expected['warn']['skeleton_baz'] = "TODO"
# expected['error'] = dict()
# self.check_results(r, expected=expected)
def check_results(testobj, report,
expected_counts={'info': 1, 'warn': 0, 'error': 0},
expected=None):
if expected is not None:
for t in expected.keys():
for r in expected[t]:
testobj.assertTrue(r in report[t],
"Could not find '%s' (%s) in:\n%s" %
(r, t, json.dumps(report, indent=2)))
for k in expected[t][r]:
testobj.assertTrue(k in report[t][r],
"Could not find '%s' (%s) in:\n%s" %
(k, r, json.dumps(report, indent=2)))
testobj.assertEqual(expected[t][r][k], report[t][r][k])
else:
for k in expected_counts.keys():
if expected_counts[k] is None:
continue
testobj.assertEqual(len(report[k]), expected_counts[k],
"(%s not equal)\n%s" %
(k, json.dumps(report, indent=2)))
|