/usr/share/pyshared/pocketlint/formatcheck.py is in python-pocket-lint 0.5.31-0ubuntu1.
This file is owned by root:root, with mode 0o644.
The actual contents of the file can be viewed below.
1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 506 507 508 509 510 511 512 513 514 515 516 517 518 519 520 521 522 523 524 525 526 527 528 529 530 531 532 533 534 535 536 537 538 539 540 541 542 543 544 545 546 547 548 549 550 551 552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568 569 570 571 572 573 574 575 576 577 578 579 580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595 596 597 598 599 600 601 602 603 604 605 606 607 608 609 610 611 612 613 614 615 616 617 618 619 620 621 622 623 624 625 626 627 628 629 630 631 632 633 634 635 636 637 638 639 640 641 642 643 644 645 646 647 648 649 650 651 652 653 654 655 656 657 658 659 660 661 662 663 664 665 666 667 668 669 670 671 672 673 674 675 676 677 678 679 680 681 682 683 684 685 686 687 688 689 690 691 692 693 694 695 696 697 698 699 700 701 702 703 704 705 706 707 708 709 710 711 712 713 714 715 716 717 718 719 720 721 722 723 724 725 726 727 728 729 730 731 732 733 734 735 736 737 738 739 740 741 742 743 744 745 746 747 748 749 750 751 752 753 754 755 756 757 758 759 760 761 762 763 764 765 766 767 768 769 770 771 772 773 774 775 776 777 778 779 780 781 782 783 784 785 786 787 788 789 790 791 792 793 794 795 796 797 798 799 800 801 802 803 804 805 806 807 808 809 810 811 812 813 814 815 816 817 818 819 820 821 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 838 839 840 841 842 843 844 845 846 847 848 849 850 851 852 853 854 855 856 857 858 859 860 861 862 863 864 865 866 867 868 869 870 871 872 873 874 875 876 877 878 879 880 881 882 883 884 885 886 887 888 889 890 891 892 893 894 895 896 897 898 899 900 901 902 903 904 905 906 907 908 909 910 911 912 913 914 915 916 917 918 919 920 921 922 923 924 925 926 927 928 929 930 931 932 933 934 935 936 937 938 939 940 941 942 943 944 945 946 947 948 949 950 951 952 953 954 955 956 957 958 959 960 | #!/usr/bin/python
# Copyright (C) 2009-2012 - Curtis Hovey <sinzui.is at verizon.net>
# This software is licensed under the MIT license (see the file COPYING).
"""Check for syntax and style problems."""
from __future__ import with_statement
__metaclass__ = type
__all__ = [
'Reporter',
'UniversalChecker',
]
import _ast
import htmlentitydefs
import logging
import mimetypes
import os
import re
import subprocess
import sys
from optparse import OptionParser
from StringIO import StringIO
from tokenize import TokenError
from xml.etree import ElementTree
try:
from xml.etree.ElementTree import ParseError
ParseError != '# Supress redefintion warning.'
except ImportError:
# Python 2.6 and below.
ParseError = object()
from xml.parsers.expat import ErrorString, ExpatError
from formatdoctest import DoctestReviewer
import contrib.pep8 as pep8
from contrib.cssccc import CSSCodingConventionChecker
from contrib.pyflakes.checker import Checker as PyFlakesChecker
try:
import cssutils
HAS_CSSUTILS = True
except ImportError:
HAS_CSSUTILS = False
def find_exec(names):
"""Return the name of a GI enabled JS interpreter."""
if os.name != 'posix':
return None
for name in names:
js = subprocess.Popen(
['which', name], stdout=subprocess.PIPE, stderr=subprocess.PIPE)
js_exec, ignore = js.communicate()
if js.returncode == 0:
return js_exec.strip()
JS = find_exec(['gjs', 'seed'])
DEFAULT_MAX_LENGTH = 80
class PocketLintPyFlakesChecker(PyFlakesChecker):
'''PocketLint checker for pyflakes.
This is here to work around some of the pyflakes problems.
'''
def __init__(self, tree, file_path='(none)', text=None):
self.text = text
if self.text:
self.text = self.text.split('\n')
super(PocketLintPyFlakesChecker, self).__init__(
tree=tree, filename=file_path)
@property
def file_path(self):
'''Alias for consistency with the rest of pocketlint.'''
return self.filename
def report(self, messageClass, *args, **kwargs):
'''Filter some errors not used in our project.'''
line_no = args[0] - 1
# Ignore explicit pyflakes:ignore requests.
if self.text and self.text[line_no].find('pyflakes:ignore') >= 0:
return
self.messages.append(messageClass(self.file_path, *args, **kwargs))
def NAME(self, node):
'''Locate name. Ignore WindowsErrors.'''
if node.id == 'WindowsError':
return
return super(PocketLintPyFlakesChecker, self).NAME(node)
class Reporter:
"""Common rules for checkers."""
CONSOLE = object()
FILE_LINES = object()
COLLECTOR = object()
def __init__(self, report_type, treeview=None):
self.report_type = report_type
self.file_lines_view = treeview
if self.file_lines_view is not None:
self.treestore = self.file_lines_view.get_model()
self.piter = None
self._last_file_name = None
self.call_count = 0
self.error_only = False
self.messages = []
def __call__(self, line_no, message, icon=None,
base_dir=None, file_name=None):
"""Report a message."""
if self.error_only and icon != 'error':
return
self.call_count += 1
args = (line_no, message, icon, base_dir, file_name)
if self.report_type == self.FILE_LINES:
self._message_file_lines(*args)
elif self.report_type == self.COLLECTOR:
self._message_collector(*args)
else:
self._message_console(*args)
def _message_console(self, line_no, message, icon=None,
base_dir=None, file_name=None):
"""Print the messages to the console."""
self._message_console_group(base_dir, file_name)
print ' %4s: %s' % (line_no, message)
def _message_console_group(self, base_dir, file_name):
"""Print the file name is it has not been seen yet."""
source = (base_dir, file_name)
if file_name is not None and source != self._last_file_name:
self._last_file_name = source
print '%s' % os.path.join('./', base_dir, file_name)
def _message_file_lines(self, line_no, message, icon=None,
base_dir=None, file_name=None):
"""Display the messages in the file_lines_view."""
if self.piter is None:
mime_type = 'gnome-mime-text'
self.piter = self.treestore.append(
None, (file_name, mime_type, 0, None, base_dir))
self.treestore.append(
self.piter, (file_name, icon, line_no, message, base_dir))
def _message_collector(self, line_no, message, icon=None,
base_dir=None, file_name=None):
self._last_file_name = (base_dir, file_name)
self.messages.append((line_no, message))
class Language:
"""Supported Language types."""
TEXT = object()
PYTHON = object()
DOCTEST = object()
CSS = object()
JAVASCRIPT = object()
SH = object()
XML = object()
XSLT = object()
HTML = object()
ZPT = object()
ZCML = object()
DOCBOOK = object()
LOG = object()
SQL = object()
RESTRUCTUREDTEXT = object()
XML_LIKE = (XML, XSLT, HTML, ZPT, ZCML, DOCBOOK)
mimetypes.add_type('application/x-zope-configuation', '.zcml')
mimetypes.add_type('application/x-zope-page-template', '.pt')
mimetypes.add_type('text/x-python-doctest', '.doctest')
mimetypes.add_type('text/x-twisted-application', '.tac')
mimetypes.add_type('text/x-log', '.log')
mimetypes.add_type('text/x-rst', '.rst')
mime_type_language = {
'text/x-python': PYTHON,
'text/x-twisted-application': PYTHON,
'text/x-python-doctest': DOCTEST,
'text/css': CSS,
'text/html': HTML,
'text/plain': TEXT,
'text/x-sql': SQL,
'text/x-log': LOG,
'text/x-rst': RESTRUCTUREDTEXT,
'application/javascript': JAVASCRIPT,
'application/xml': XML,
'application/x-sh': SH,
'application/x-zope-configuation': ZCML,
'application/x-zope-page-template': ZPT,
}
doctest_pattern = re.compile(
r'^.*(doc|test|stories).*/.*\.(txt|doctest)$')
@staticmethod
def get_language(file_path):
"""Return the language for the source."""
# Doctests can easilly be mistyped, so it must be checked first.
if Language.doctest_pattern.match(file_path):
return Language.DOCTEST
mime_type, encoding = mimetypes.guess_type(file_path)
if mime_type is None:
# This could be a very bad guess.
return Language.TEXT
elif mime_type in Language.mime_type_language:
return Language.mime_type_language[mime_type]
elif mime_type in Language.XML_LIKE:
return Language.XML
elif mime_type.endswith('+xml'):
return Language.XML
elif 'text/' in mime_type:
return Language.TEXT
else:
return None
@staticmethod
def is_editable(file_path):
""" Only search mime-types that are like sources can open.
A fuzzy match of text/ or +xml is good, but some files types are
unknown or described as application data.
"""
return Language.get_language(file_path) is not None
class BaseChecker:
"""Common rules for checkers.
The Decedent must provide self.file_name and self.base_dir
"""
def __init__(self, file_path, text, reporter=None, options=None):
self.file_path = file_path
self.base_dir = os.path.dirname(file_path)
self.file_name = os.path.basename(file_path)
self.text = text
self.set_reporter(reporter=reporter)
self.options = options
def set_reporter(self, reporter=None):
"""Set the reporter for messages."""
if reporter is None:
reporter = Reporter(Reporter.CONSOLE)
self._reporter = reporter
def message(self, line_no, message, icon=None,
base_dir=None, file_name=None):
"""Report the message."""
if base_dir is None:
base_dir = self.base_dir
if file_name is None:
file_name = self.file_name
self._reporter(
line_no, message, icon=icon,
base_dir=base_dir, file_name=file_name)
def check(self):
"""Check the content."""
raise NotImplementedError
@property
def check_length_filter(self):
'''Default filter used by default for checking line length.'''
if self.options:
return self.options.max_line_length
else:
return DEFAULT_MAX_LENGTH
class UniversalChecker(BaseChecker):
"""Check and reformat doctests."""
def __init__(self, file_path, text,
language=None, reporter=None, options=None):
self.file_path = file_path
self.base_dir = os.path.dirname(file_path)
self.file_name = os.path.basename(file_path)
self.text = text
self.set_reporter(reporter=reporter)
self.language = language
self.options = options
self.file_lines_view = None
def check(self):
"""Check the file syntax and style."""
if self.language is Language.PYTHON:
checker_class = PythonChecker
elif self.language is Language.DOCTEST:
checker_class = DoctestReviewer
elif self.language is Language.CSS:
checker_class = CSSChecker
elif self.language in Language.XML_LIKE:
checker_class = XMLChecker
elif self.language is Language.JAVASCRIPT:
checker_class = JavascriptChecker
elif self.language is Language.LOG:
# Log files are not source, but they are often in source code
# trees.
pass
else:
checker_class = AnyTextChecker
checker = checker_class(
self.file_path, self.text, self._reporter, self.options)
checker.check()
class AnyTextMixin:
"""Common checks for many checkers."""
def check_conflicts(self, line_no, line):
"""Check that there are no merge conflict markers."""
if line.startswith('<' * 7) or line.startswith('>' * 7):
self.message(line_no, 'File has conflicts.', icon='errror')
def check_length(self, line_no, line):
"""Check the length of the line."""
max_length = self.check_length_filter
if len(line) > max_length:
self.message(
line_no, 'Line exceeds %s characters.' % max_length,
icon='info')
def check_trailing_whitespace(self, line_no, line):
"""Check for the presence of trailing whitespace in the line."""
if line.endswith(' '):
self.message(
line_no, 'Line has trailing whitespace.', icon='info')
def check_tab(self, line_no, line):
"""Check for the presence of tabs in the line."""
if '\t' in line:
self.message(
line_no, 'Line contains a tab character.', icon='info')
class AnyTextChecker(BaseChecker, AnyTextMixin):
"""Verify the text of the document."""
def check(self):
"""Call each line_method for each line in text."""
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
self.check_length(line_no, line)
self.check_trailing_whitespace(line_no, line)
self.check_conflicts(line_no, line)
class SQLChecker(BaseChecker, AnyTextMixin):
"""Verify SQL style."""
def check(self):
"""Call each line_method for each line in text."""
# Consider http://code.google.com/p/python-sqlparse/ to verify
# keywords and reformatting.
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
self.check_trailing_whitespace(line_no, line)
self.check_tab(line_no, line)
self.check_conflicts(line_no, line)
class XMLChecker(BaseChecker, AnyTextMixin):
"""Check XML documents."""
xml_decl_pattern = re.compile(r'<\?xml .*?\?>')
xhtml_doctype = (
u'<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" '
u'"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">')
def check(self):
"""Check the syntax of the python code."""
if self.text == '':
return
parser = ElementTree.XMLParser()
parser.entity.update(htmlentitydefs.entitydefs)
offset = 0
try:
# This is a sanity check to work with the true text....
text = unicode(self.text.decode('utf-8').encode('utf-8'))
except UnicodeDecodeError:
# ...but this fallback is okay since this check is about markup.
text = self.text.decode('ascii', 'ignore').encode('utf-8')
if text.find('<!DOCTYPE') == -1:
# Expat requires a doctype to honour parser.entity.
offset = 1
match = self.xml_decl_pattern.search(text)
if match is None:
text = self.xhtml_doctype + '\n' + text
else:
start, end = match.span(0)
text = text[:start] + self.xhtml_doctype + '\n' + text[end:]
elif text.find('<!DOCTYPE html>') != -1:
text = text.replace('<!DOCTYPE html>', self.xhtml_doctype)
try:
ElementTree.parse(StringIO(text), parser)
except (ExpatError, ParseError), error:
if hasattr(error, 'code'):
error_message = ErrorString(error.code)
if hasattr(error, 'position') and error.position:
error_lineno, error_charno = error.position
error_lineno = error_lineno - offset
elif error.lineno:
# Python 2.6-
error_lineno = error.lineno - offset
else:
error_lineno = 0
else:
error_message, location = str(error).rsplit(':')
error_lineno = int(location.split(',')[0].split()[1]) - offset
self.message(error_lineno, error_message, icon='error')
self.check_text()
def check_text(self):
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
self.check_trailing_whitespace(line_no, line)
self.check_conflicts(line_no, line)
class CSSReporterHandler(logging.Handler):
"""A logging handler that uses the checker to report issues."""
error_pattern = re.compile(
r'(?P<issue>[^(]+): \((?P<text>[^,]+, [^,]+), (?P<lineno>\d+).*')
message_pattern = re.compile(
r'(?P<issue>[^:]+:[^:]+): (?P<text>.*) (?P<lineno>0)$')
def __init__(self, checker):
logging.Handler.__init__(self, logging.INFO)
self.checker = checker
def handleError(self, record):
pass
def emit(self, record):
if record.levelname == 'ERROR':
icon = 'error'
else:
icon = 'info'
matches = self.checker.message_pattern.search(record.getMessage())
if matches is None:
matches = self.error_pattern.search(record.getMessage())
try:
line_no = matches.group('lineno')
message = "%s: %s" % (
matches.group('issue'), matches.group('text'))
except AttributeError:
line_no = 0
message = record.getMessage()
self.checker.message(int(line_no), message, icon=icon)
class CSSChecker(BaseChecker, AnyTextMixin):
"""Check XML documents."""
message_pattern = re.compile(
r'[^ ]+ (?P<issue>.*) \[(?P<lineno>\d+):\d+: (?P<text>.+)\]')
def check(self):
"""Check the syntax of the CSS code."""
if self.text == '':
return
self.check_cssutils()
self.check_text()
# CSS coding conventoins checks should go last since they rely
# on previous checks.
self.check_css_coding_conventions()
def check_cssutils(self):
"""Check the CSS code by parsing it using CSSUtils module."""
if not HAS_CSSUTILS:
return
handler = CSSReporterHandler(self)
log = logging.getLogger('pocket-lint')
log.addHandler(handler)
log.propagate = False
parser = cssutils.CSSParser(
log=log, loglevel=logging.INFO, raiseExceptions=False)
parser.parseString(self.text)
log.removeHandler(handler)
def check_text(self):
"""Call each line_method for each line in text."""
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
self.check_length(line_no, line)
self.check_trailing_whitespace(line_no, line)
self.check_conflicts(line_no, line)
self.check_tab(line_no, line)
def check_css_coding_conventions(self):
"""Check the input using CSS Coding Convention checker."""
CSSCodingConventionChecker(self.text, logger=self.message).check()
class PythonChecker(BaseChecker, AnyTextMixin):
"""Check python source code."""
# This regex is taken from PEP 0263.
encoding_pattern = re.compile("coding[:=]\s*([-\w.]+)")
def __init__(self, file_path, text, reporter=None, options=None):
super(PythonChecker, self).__init__(
file_path, text, reporter, options)
self.encoding = 'ascii'
def check(self):
"""Check the syntax of the python code."""
if self.text == '':
return
self.check_text()
self.check_flakes()
self.check_pep8()
def check_flakes(self):
"""Check compilation and syntax."""
try:
tree = compile(
self.text, self.file_path, "exec", _ast.PyCF_ONLY_AST)
except (SyntaxError, IndentationError), exc:
line_no = exc.lineno or 0
line = exc.text or ''
explanation = 'Could not compile; %s' % exc.msg
message = '%s: %s' % (explanation, line.strip())
self.message(line_no, message, icon='error')
else:
warnings = PocketLintPyFlakesChecker(
tree, file_path=self.file_path, text=self.text)
for warning in warnings.messages:
dummy, line_no, message = str(warning).split(':')
self.message(int(line_no), message.strip(), icon='error')
def check_pep8(self):
"""Check style."""
try:
# Monkey patch pep8 for direct access to the messages.
original_report_error = pep8.Checker.report_error
def pep8_report_error(ignore, line_no, offset, message, check):
self.message(line_no, message, icon='info')
pep8.Checker.report_error = pep8_report_error
original_max_line_length = pep8.MAX_LINE_LENGTH
pep8.MAX_LINE_LENGTH = self.check_length_filter
pep8.process_options([self.file_path])
try:
pep8.Checker(self.file_path).check_all()
except TokenError, er:
message, location = er.args
self.message(location[0], message, icon='error')
except IndentationError, er:
message, location = er.args
message = "%s: %s" % (message, location[3].strip())
self.message(location[1], message, icon='error')
finally:
pep8.MAX_LINE_LENGTH = original_max_line_length
pep8.Checker.report_error = original_report_error
def check_text(self):
"""Call each line_method for each line in text."""
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
if line_no in (1, 2):
match = self.encoding_pattern.search(line)
if match:
self.encoding = match.group(1).lower()
self.check_pdb(line_no, line)
self.check_conflicts(line_no, line)
self.check_ascii(line_no, line)
def check_pdb(self, line_no, line):
"""Check the length of the line."""
pdb_call = 'pdb.' + 'set_trace'
if pdb_call in line:
self.message(
line_no, 'Line contains a call to pdb.', icon='error')
@property
def check_length_filter(self):
# The pep8 lib counts from 0.
if self.options:
return self.options.max_line_length - 1
else:
return pep8.MAX_LINE_LENGTH
def check_ascii(self, line_no, line):
"""Check that the line is ascii."""
if self.encoding != 'ascii':
return
try:
line.encode('ascii')
except UnicodeEncodeError, error:
self.message(
line_no, 'Non-ascii characer at position %s.' % error.end,
icon='error')
class JavascriptChecker(BaseChecker, AnyTextMixin):
"""Check python source code."""
HERE = os.path.dirname(__file__)
FULLJSLINT = os.path.join(HERE, 'contrib/fulljslint.js')
JSREPORTER = os.path.join(HERE, 'jsreporter.js')
def check(self):
"""Check the syntax of the javascript code."""
if JS is None or self.text == '':
return
args = [JS, self.JSREPORTER, self.FULLJSLINT, self.file_path]
jslint = subprocess.Popen(
args, stdout=subprocess.PIPE, stderr=subprocess.PIPE)
issues, errors = jslint.communicate()
issues = issues.strip()
if issues:
for issue in issues.splitlines():
line_no, char_no_, message = issue.split('::')
line_no = int(line_no)
line_no -= 1
self.message(line_no, message, icon='error')
self.check_text()
def check_debugger(self, line_no, line):
"""Check the length of the line."""
debugger_call = 'debugger;'
if debugger_call in line:
self.message(
line_no, 'Line contains a call to debugger.', icon='error')
def check_text(self):
"""Call each line_method for each line in text."""
for line_no, line in enumerate(self.text.splitlines()):
line_no += 1
self.check_debugger(line_no, line)
self.check_length(line_no, line)
self.check_trailing_whitespace(line_no, line)
self.check_conflicts(line_no, line)
self.check_tab(line_no, line)
class ReStructuredTextChecker(BaseChecker, AnyTextMixin):
"""Check reStructuredText ource code."""
# Taken from rst documentation.
delimiter_characters = [
'=', '-', '`', ':', '\'', '"', '~', '^', '_', '*', '+', '#', '<', '>',
]
def __init__(self, file_path, text, reporter=None):
super(ReStructuredTextChecker, self).__init__(
file_path, text, reporter=reporter)
self.lines = self.text.splitlines()
def check(self):
"""Check the syntax of the reStructuredText code."""
self.check_lines()
self.check_empty_last_line()
def check_lines(self):
"""Call each line checker for each line in text."""
for line_no, line in enumerate(self.lines):
line_no += 1
self.check_length(line_no, line)
self.check_trailing_whitespace(line_no, line)
self.check_tab(line_no, line)
self.check_conflicts(line_no, line)
if self.isTransition(line_no - 1):
self.check_transition(line_no - 1)
elif self.isSectionDelimiter(line_no - 1):
self.check_section_delimiter(line_no - 1)
else:
pass
def isTransition(self, line_number):
'''Return True if the current line is a line transition.'''
line = self.lines[line_number]
if len(line) < 4:
return False
if len(self.lines) < 3:
return False
succesive_characters = (
line[0] == line[1] == line[2] == line[3] and
line[0] in self.delimiter_characters)
if not succesive_characters:
return False
emply_lines_bounded = (
self.lines[line_number - 1] == '' and
self.lines[line_number + 1] == '')
if not emply_lines_bounded:
return False
return True
def check_transition(self, line_number):
'''Transitions should be delimited by a single emtpy line.'''
if (self.lines[line_number - 2] == '' or
self.lines[line_number + 2] == ''):
self.message(
line_number + 1,
'Transition markers should be bounded by single empty lines.',
icon='info',
)
def isSectionDelimiter(self, line_number):
'''Return true if the line is a section delimiter.'''
if len(self.lines) < 3:
return False
if line_number >= len(self.lines):
return False
line = self.lines[line_number]
if len(line) < 3:
return False
if (line[0] == line[1] == line[2] and line[0] in
self.delimiter_characters):
if ' ' in line:
# We have a table header.
return False
else:
return True
return False
def check_section_delimiter(self, line_number):
"""Checks for section delimiter.
These checkes are designed for sections delimited by top and bottom
markers.
======= <- top marker
Section <- text_line
======= <- bottom marker
If the section is delimted only by bottom marker, the section text
is considered the top marker.
Section <- top marker, text_line
======= <- bottom marker
If the section has a custom anchor name:
.. _link <- top marker
=======
Section <- text_line
======= <- bottom marker
or:
.. _link <- top marker
Section <- text_line
======= <- bottom marker
If we have top and bottom markers, the check will be called twice (
for each marker). In this case we will skip the tests for bottom
marker.
"""
human_line_number = line_number + 1
current_line = self.lines[line_number]
# Skip test if we have both top and bottom markers and we are
# at the bottom marker.
if (line_number > 1 and current_line == self.lines[line_number - 2]):
return
if ((line_number + 2) < len(self.lines) and
current_line == self.lines[line_number + 2]):
# We have both top and bottom markers and we are currently at
# the top marker.
top_marker = line_number
text_line = line_number + 1
bottom_marker = line_number + 2
else:
# We only have bottom marker, and are at the bottom marker.
top_marker = line_number - 1
text_line = line_number - 1
bottom_marker = line_number
# In case we have a custom anchor, the top_marker is replaced by
# the custom anchor.
if self._sectionHasCustomAnchor(top_marker):
top_marker = top_marker - 2
# Check underline length for bottom marker,
# since top marker can be the same as text line.
if len(self.lines[bottom_marker]) != len(self.lines[text_line]):
self.message(
human_line_number,
'Section marker has wrong length.',
icon='error',
)
if not self._haveGoodSpacingBeforeSection(top_marker):
self.message(
human_line_number,
'Section should be divided by 2 empty lines.',
icon='info',
)
if not self._haveGoodSpacingAfterSection(bottom_marker):
self.message(
human_line_number,
'Section title should be followed by 1 empty line.',
icon='info',
)
def _sectionHasCustomAnchor(self, top_marker):
if (top_marker - 2) < 0:
return False
if self.lines[top_marker - 2].startswith('.. _'):
return True
return False
def _haveGoodSpacingBeforeSection(self, top_marker):
'''Return True if we have good spacing before the section.'''
if top_marker > 0:
if self.lines[top_marker - 1] != '':
return False
# If we are on the second line, there is no space for 2 empty lines
# before.
if top_marker == 1:
return False
if top_marker > 1:
if self.lines[top_marker - 2] != '':
return False
if top_marker > 2:
if self.lines[top_marker - 3] == '':
return False
return True
def _haveGoodSpacingAfterSection(self, bottom_marker):
'''Return True if we have good spacing after the section.'''
lines_count = len(self.lines)
if bottom_marker < lines_count - 1:
if self.lines[bottom_marker + 1] != '':
return False
if bottom_marker < lines_count - 2:
if self.lines[bottom_marker + 2] == '':
# If the section is followed by 2 empty spaces and then
# followed by a section delimiter, the section delimiter
# rules will take priority
if self.isSectionDelimiter(bottom_marker + 3):
return True
if self.isSectionDelimiter(bottom_marker + 4):
return True
return False
return True
def check_empty_last_line(self):
"""Chech the files ends with an emtpy line and not with double empty
line.
This will avoid merge conflicts.
"""
if len(self.lines) < 2:
return
if self.text[-1] != '\n' or self.text[-2:] == '\n\n':
self.message(
len(self.lines),
'File does not ends with an empty line.',
icon='info',
)
def get_option_parser():
"""Return the option parser for this program."""
usage = "usage: %prog [options] file1 file2"
parser = OptionParser(usage=usage)
parser.add_option(
"-v", "--verbose", action="store_true", dest="verbose",
help="show errors and warngings.")
parser.add_option(
"-q", "--quiet", action="store_false", dest="verbose",
help="Show errors only.")
parser.add_option(
"-f", "--format", dest="do_format", action="store_true",
help="Reformat the doctest.")
parser.add_option(
"-i", "--interactive", dest="is_interactive", action="store_true",
help="Approve each change.")
parser.add_option(
"-m", "--max-length", dest="max_line_length", type="int",
help="Set the max line length (default %s)" % DEFAULT_MAX_LENGTH)
parser.set_defaults(
verbose=True,
do_format=False,
is_interactive=False,
max_line_length=DEFAULT_MAX_LENGTH,
)
return parser
def check_sources(sources, options, reporter=None):
if reporter is None:
reporter = Reporter(Reporter.CONSOLE)
reporter.call_count = 0
for source in sources:
file_path = os.path.normpath(source)
if os.path.isdir(source) or not Language.is_editable(source):
continue
language = Language.get_language(file_path)
with open(file_path) as file_:
text = file_.read()
if language is Language.DOCTEST and options.do_format:
formatter = DoctestReviewer(text, file_path, reporter)
formatter.format_and_save(options.is_interactive)
checker = UniversalChecker(
file_path, text, language, reporter, options=options)
checker.check()
return reporter.call_count
def main(argv=None):
"""Run the command line operations."""
if argv is None:
argv = sys.argv
parser = get_option_parser()
(options, sources) = parser.parse_args(args=argv[1:])
# Handle standard args.
if len(sources) == 0:
parser.error("Expected file paths.")
reporter = Reporter(Reporter.CONSOLE)
reporter.error_only = not options.verbose
return check_sources(sources, options, reporter)
if __name__ == '__main__':
sys.exit(main())
|